Add C implementation for @stdlib/math/base/special/acovercos
#1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Mar 2, 2024
Contributor
stdlib-bot
left a comment
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
kgryte
added
Feature
kgryte
reviewed
Mar 2, 2024
kgryte
reviewed
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/acovercos/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/acovercos/examples/c/example.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/acovercos/lib/native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/acovercos/lib/native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/acovercos/lib/native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/acovercos/manifest.json
Outdated
Show resolved
Hide resolved
kgryte
requested changes
Mar 2, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
@adarshpalaskar1 Thanks for working on this. The main outstanding thing which needs to be finished based on my initial review are the examples in the /lib/native.js file.
@Pranavchiku Given that you worked previously on similar packages, does this PR satisfy the necessary changes?
kgryte
added
the
Needs Changes
Member
|
I'll check those once he applies code review and revert back. |
adarshpalaskar1
force-pushed
the
acovercos
branch
from
44751e4 to
fd1021e
Compare
Pranavchiku
approved these changes
Mar 2, 2024
Member
Pranavchiku
left a comment
Pranavchiku
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @adarshpalaskar1 !
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
added
Ready To Merge
bad-in-coding
pushed a commit
to bad-in-coding/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1446 Closes: stdlib-js#775 --------- Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #775.
Description
Related Issues
This pull request:
@stdlib/math/base/special/acovercos#775Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers